Re: [PATCH] MAMA: Made logging more accurate in MAMA Ft


Damian Maguire <DMaguire@...>
 

Cheers Frank, 

Raised this as BZ155. Simple change, so it should hit next shortly.

Cheers, 

D

From: Frank Quinn <fquinn@...>
Date: Tuesday, July 29, 2014 9:41 AM
To: "openmama-dev@..." <openmama-dev@...>
Subject: [Openmama-dev] [PATCH] MAMA: Made logging more accurate in MAMA Ft

In some MAMA FT Timers, the timer callback always reports that it is a

"multicast" FT type, when in fact that code is shared for all FT types.

This is misleading to the MAMA application developer who is trying to

troubleshoot FT issues, so this patch will make the logging a little

more clear.

 

Signed-off-by: Frank Quinn <fquinn@...>

---

mama/c_cpp/src/c/ft.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

 

diff --git a/mama/c_cpp/src/c/ft.c b/mama/c_cpp/src/c/ft.c

index c5b2c85..dca288b 100644

--- a/mama/c_cpp/src/c/ft.c

+++ b/mama/c_cpp/src/c/ft.c

@@ -628,7 +628,7 @@ ftHeartbeatTimerCb (mamaTimer          timer,

                          void*              closure)

{

     mamaFtMemberImpl* impl = (mamaFtMemberImpl*)closure;

-    mama_log (MAMA_LOG_LEVEL_FINEST, "MAMA multicast FT: heartbeat timer has fired");

+    mama_log (MAMA_LOG_LEVEL_FINEST, "MAMA FT: heartbeat timer has fired");

     impl->myHeartbeatTick++;

     impl->ftSendHeartbeat (impl);

}

@@ -639,7 +639,7 @@ ftTimeoutTimerCb (mamaTimer          timer,

{

     mamaFtMemberImpl* impl = (mamaFtMemberImpl*)closure;

     mama_log (MAMA_LOG_LEVEL_FINE,

-              "MAMA multicast FT: timeout timer has fired; Going Active");

+              "MAMA FT: timeout timer has fired; Going Active");

     foundheartbeat=0;

--

1.9.3

 


This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of Intercontinental Exchange, Inc. (ICE), Euronext or any of their subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.

This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of Intercontinental Exchange, Inc. (ICE), Euronext or any of their subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.

Join Openmama-dev@lists.openmama.org to automatically receive all group messages.