Re: windows/*.h headers file missing in windows build.

Damian Maguire

In this instance I believe not - since the main windows folder contains a great large amount of source code, it may also eventually also contain some non-public headers, which wouldn't be considered for part of a release. Specifying each header in the SConscript ensures that a deliberate action is taken to expose the headers (and ensures that major changes aren't required if a non-public header is required later), and limits the possibility that things will fall out accidentally. The other folder being globbed is a different situation, since it should always only contain public headers.



On Thu, Aug 28, 2014 at 12:43 PM, Benjamin Taieb <benjamin.taieb@...> wrote:

Hi Damian,

Looked at the diff, wouldn't you do


winheaders = Glob('windows/*.h')


to be sure to capture any further windows headers ?




From: Damian Maguire [mailto:damian@...]
Sent: 28 August 2014 10:44
To: Benjamin Taieb
Cc: openmama-dev@...
Subject: Re: [Openmama-dev] windows/*.h headers file missing in windows build.


Hey Benjamin, 


Thanks for pointing that one out, it does look like a bug with the common I've pushed out a fix for it into next, if you'd like to give it a look now.






On Thu, Aug 28, 2014 at 7:45 AM, Benjamin Taieb <benjamin.taieb@...> wrote:

Hi list,

When comparing the  binaries release

and what I get through compiling from source, the windows headers file (mman.h anfd lock.h) are not included.

Further investigation show that common\c_cpp\src\c\ is missing to install windows headers file.


Is that a bug for which I should submit a patch or these headers are not suppose to be in the distribution ?




Openmama-dev mailing list


Join to automatically receive all group messages.