VectorChar and VectorBool field type enumerator


Alireza Assadzadeh <Alireza.Assadzadeh@...>
 

Hi folks,

 

I noticed that VectorChar and VectorBool do not have  a field type enumerator  in Mama (i.e. mamaFieldType enum in mama/fielddesc.h). Also, the related code for VectorChar and VectorBool in C/ C++, C#, JNI does not have the type related implementations for these vector types as compared to other vector types, such as VectorU32 (enumerator: MAMA_FIELD_TYPE_VECTOR_U32).

 

I imagine these types may not be widely and there are alternatives field types for them(e.g. Opaque, String and unsinged integer).

 

Should VectorChar and VectorBool  types be included in the mamaFieldType enum? For example with the numbers shown below:

 

<code>

diff --git a/mama/c_cpp/src/c/mama/fielddesc.h b/mama/c_cpp/src/c/mama/fielddesc.h

index e3af6e1..a374489 100644

--- a/mama/c_cpp/src/c/mama/fielddesc.h

+++ b/mama/c_cpp/src/c/mama/fielddesc.h

@@ -90,6 +90,8 @@ typedef enum mamaFieldType_

     MAMA_FIELD_TYPE_PRICE         =   27,

 

     /** Array type support */

+    MAMA_FIELD_TYPE_VECTOR_BOOL   =   29,

+    MAMA_FIELD_TYPE_VECTOR_CHAR   =   30,

     MAMA_FIELD_TYPE_VECTOR_I8     =   34,

     MAMA_FIELD_TYPE_VECTOR_U8     =   35,

     MAMA_FIELD_TYPE_VECTOR_I16    =   36,

</code>

 

And then also have the corresponding type related changes in the rest of Mama codebase?

 

Regards,.

 

--Alireza

Join {Openmama-dev@lists.openmama.org to automatically receive all group messages.