Re: [PATCH 3/3] [MAMAC] mamaPublisherImpl_getTransportImpl() accessor
Alireza Assadzadeh <Alireza.Assadzadeh@...>
Hi Gary,
toggle quoted messageShow quoted text
Thanks for the patch. I had some minor comments which I marked inline below with [AA:] --Alireza
-----Original Message-----[AA:] I suggest dropping the 'Impl' in the new function name and making it part of the public API. So, calling it mamaPublisher_getTransport. Signed-off-by: Gary Molloy <g.molloy@...>[AA:] Can the symantics be changed to the following instead? MAMAExpDLL extern mama_status mamaSubscription_getTransport ( mamaPublisher publisher, mamaTransport *transport); This makes it also consistent with the similar function mamaSubscription_getTransport diff --git a/mama/c_cpp/src/c/publisherimpl.h[AA:] I suggest moving the function declaration to the public API header mama/c_cpp/src/c/mama/publisher.h instead of mama/c_cpp/src/c/publisherimpl.h. The function can be generally useful to the API users. On the subscription side we have the mamaSubscription_getTransport which is similar. [snip]
|
|