[PATCH 13/14] UNITTEST: Remove presumptuous isTportDisconnected test
Frank Quinn <fquinn.ni@...>
I don't think it's reasonable to expect a unit test around OpenMAMA to support this function call as the nature of transport connectivity will vary across all middlewares. In the instance of Avis, it is never really in a disconnected state and there are doubtless other middleware implementations that are not connection oriented at all and for which this test doesn't really make any sense, so I'm taking it out. Signed-off-by: Frank Quinn <fquinn.ni@...> --- .../c/middleware/middlewareSubscriptionTests.cpp | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/mama/c_cpp/src/gunittest/c/middleware/middlewareSubscriptionTests.cpp b/mama/c_cpp/src/gunittest/c/middleware/middlewareSubscriptionTests.cpp index 6f19c2e..e6eccbf 100644 --- a/mama/c_cpp/src/gunittest/c/middleware/middlewareSubscriptionTests.cpp +++ b/mama/c_cpp/src/gunittest/c/middleware/middlewareSubscriptionTests.cpp @@ -424,24 +424,6 @@ TEST_F (MiddlewareSubscriptionTests, getPlatformErrorInvalidSubBridge) status); } -TEST_F (MiddlewareSubscriptionTests, isTportDisconnected) -{ - int res = NULL; - ASSERT_EQ(MAMA_STATUS_OK, - mamaSubscription_create(parent, queue, &callbacks, source, sourceName, closure)); - - ASSERT_EQ(MAMA_STATUS_OK, - mBridge->bridgeMamaSubscriptionCreate(&subscriber, sourceName, symbol, - tport, queue, callbacks, - parent, closure)); - - res=mBridge->bridgeMamaSubscriptionIsTportDisconnected(subscriber); - ASSERT_TRUE(res != NULL); - - ASSERT_EQ(MAMA_STATUS_OK, - mBridge->bridgeMamaSubscriptionDestroy(subscriber)); -} - TEST_F (MiddlewareSubscriptionTests, isTportDisconnectedInvalid) { ASSERT_EQ (MAMA_STATUS_NULL_ARG, -- 2.4.3 |
|