Re: [PATCH] [common] Added some other pthread calls to linux os abstraction layer
Ian Bell <IBell@...>
Hi Miketoggle quoted messageShow quoted text
As you have pointed out below adding this to windows is a bit less straightforward and requires a bit more testing. I was going to bundle the windows code together with some other patches i have for the windows layer to cut down on the testing effort.
To this end iI have also been adding some unittests to the common folder to facilitate testing of these components separately from mama.
As i have not yet submitted any patches which require this feature to be present in the abstraction layer i can hold this patch until such time as the windows version is ready if you prefer.
From: Mike Schonberg
Sent: 23 May 2012 01:32
To: Ian Bell; email@example.com
Subject: RE: [PATCH] [common] Added some other pthread calls to linux os abstraction layer
I believe that we need equivalents defined in common/.../windows/lock.h.
On Fri, 18 May 2012, Ian Bell wrote:
This can be a no-op as Windows condition variables are always recursive.
We may need to change the implementation to use Windows condition variables or or change the Event to be manual reset and add locking/and a condition variable to ensure the desired number of threads run (one or all).
#define wthread_spinlock_t pthread_spinlock_tThis will be a no-op as well.
Please consider the environment before printing this e-mail.
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient or have received this e-mail in error, please advise the sender immediately by reply e-mail and delete this message and any attachments without retaining a copy.
Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.