Re: openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials [I]
Classification: For internal use only
Thank you Aaron, I will give your suggestion a try.
To reproduce the issue you will need a transport returning multiple initial snapshots for your group subscription. Without that conditional I was referring to and with DQ strategy disabled crash will happen handling second snapshot from the group.
From: Aaron Sneddon [mailto:asneddon@...]
Sent: 18 декабря 2018 г. 17:06
To: Igor Kovalenko <igor.kovalenko@...>; Frank Quinn <fquinn@...>; openmama-dev@...
Cc: Gary Molloy <gmolloy@...>; Philip McCausland <pmccausland@...>
Subject: FW: [Openmama-dev] openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials
I tried the various config options to reproduce the issue (as there are transport specific and global config options for disabling dq strategy). With regards to the missing conditional:
I can see that around the line of the change we have taken out the following conditional which I assume you are referring to:
I would just point out that this conditional statement hasn’t been removed, but was relocated to
I cannot recommend duplicating the conditional statement, as this would be unnecessary and as I cannot reproduce your issue I can only make a suggestion that hopefully you could try?
At present mamaPlugin_fireSubscriptionPreMsgHook returns MAMA_STATUS_OK in all cases. My suggestion is, in dqstrategyplugin.c, at line 478, change MAMA_STATUS_OK
to MAMA_STATUS_INVALID_ARG (for example).
This would now emulate the previous functionality (but does not duplicate the conditional).
I have done this myself and performed a quick check that it does not break anything and it looks fine. But as I say, I cannot replicate your issue and so cannot do a full check. I would therefore say that if it suits, you could change that single line in dqstrategyplugin.c and add the check in listenermsgcallback, and run a test to see if this fixes your issue.
I am still concerned as to why I cannot reproduce the same issue, but please let me know what you think.
Aaron / Vela, could someone have a look please?
On 12 Nov 2018 19:36, Frank Quinn <frank@...> wrote:
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.