Re: [PATCH 2.1 1/1] Introduce support for Solace Systems as a middleware provider in required enumerations


Mark Spielman
 

Thank you for the feedback. Patch resubmitted in separate email with enum corrected.

 

From: Glenn McClements [mailto:gmcclements@...]
Sent: Friday, September 07, 2012 6:55 AM
To: Tom Doust; Mark Spielman; openmama-dev@...
Cc: Les Spiro
Subject: Re: [Openmama-dev] [PATCH 2.1 1/1] Introduce support for Solace Systems as a middleware provider in required enumerations

 

Mark,

Tick42 got in first this time round, so can you please update your enum value and resubmit.

 

In the future we'll put a process in place for this. Longer term we'll probably get rid of the hard coded enum values altogether and allow bridges to be picked up fully dynamically, as has been discussed previously on this list. 

 

Thanks,

Glenn 

 

From: Tom Doust <tom.doust@...>
Date: Fri, 7 Sep 2012 09:43:16 +0000
To: Mark Spielman <Mark.Spielman@...>, "openmama-dev@..." <openmama-dev@...>
Cc: Les Spiro <lspiro@...>
Subject: Re: [Openmama-dev] [PATCH 2.1 1/1] Introduce support for Solace Systems as a middleware provider in required enumerations

 

Hi

 

We already used this enumerator value in the patch we submitted 3 weeks ago (attached)

 

I'm not sure what the process is to resolve this sort of thing

 

Rgds

 

Tom Doust

 

TOM DOUST | Head of Consultancy                                                                                                         


TICK42

P:+44 (0) 1628 477444 |M: +44 (0) 7710 479924 | E: tom.doust@...| http://www.tick42.com 


 

 

 

 

-----Original Message-----
From: openmama-dev-bounces@... [mailto:openmama-dev-bounces@...] On Behalf Of Mark Spielman
Sent: 07 September 2012 2:22 AM
To: openmama-dev@...
Subject: [Openmama-dev] [PATCH 2.1 1/1] Introduce support for Solace Systems as a middleware provider in required enumerations

 

Add Solace Systems to the list of middleware providers in the middleware enumeration and string conversion methods. The goal of this submission is to allow Solace Systems to provide OpenMAMA middleware bridge libraries in the near future.

 

Signed-off-by: Mark Spielman <mark.spielman@...>

 

---

 

diff --git a/mama/c_cpp/src/c/mama/middleware.h b/mama/c_cpp/src/c/mama/middleware.h

index 38ff9be..990de83 100644

--- a/mama/c_cpp/src/c/mama/middleware.h

+++ b/mama/c_cpp/src/c/mama/middleware.h

@@ -37,7 +37,8 @@ typedef enum mamaMiddleware_

     MAMA_MIDDLEWARE_LBM     = 1,

     MAMA_MIDDLEWARE_TIBRV   = 2,

     MAMA_MIDDLEWARE_AVIS    = 3,

-    MAMA_MIDDLEWARE_MAX     = 4,

+    MAMA_MIDDLEWARE_SOLACE  = 4,

+    MAMA_MIDDLEWARE_MAX     = 5,

     MAMA_MIDDLEWARE_UNKNOWN = 99

} mamaMiddleware;

diff --git a/mama/c_cpp/src/c/middleware.c b/mama/c_cpp/src/c/middleware.c index ad288ad..7acc66e 100644

--- a/mama/c_cpp/src/c/middleware.c

+++ b/mama/c_cpp/src/c/middleware.c

@@ -41,6 +41,9 @@ mamaMiddleware_convertFromString (const char*  str)

     if (strcasecmp (str, "avis") == 0)

         return MAMA_MIDDLEWARE_AVIS;

+    if (strcasecmp (str, "solace") == 0)

+        return MAMA_MIDDLEWARE_SOLACE;

+

     return MAMA_MIDDLEWARE_UNKNOWN;

}

@@ -59,6 +62,8 @@ mamaMiddleware_convertToString (mamaMiddleware  middleware)

             return "tibrv";

         case MAMA_MIDDLEWARE_AVIS:

             return "AVIS";

+        case MAMA_MIDDLEWARE_SOLACE:

+            return "SOLACE";

         default:

             return "unknown";

     }

 

 

 

 

 

---------------------------------------------------------------------------------------

 

Mark Spielman

Development Lead, Solace Systems Professional Services

+1-613-271-1010 x1021

mark.spielman@...

www.solacesystems.com

 

 

_______________________________________________

Openmama-dev mailing list

Openmama-dev@...

https://lists.openmama.org/mailman/listinfo/openmama-dev

 

_______________________________________________ Openmama-dev mailing list Openmama-dev@... https://lists.openmama.org/mailman/listinfo/openmama-dev



Please consider the environment before printing this e-mail.

This e-mail may contain confidential and/or privileged information. If you are not the intended recipient or have received this e-mail in error, please advise the sender immediately by reply e-mail and delete this message and any attachments without retaining a copy.

Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

Join Openmama-dev@lists.openmama.org to automatically receive all group messages.