Openmama-dev@lists.openmama.org

Home Messages Hashtags Subgroups

Export Group Data

Between

and

Re: openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials [I] Igor Kovalenko #2231 Classification: For internal use only Thank you Aaron, I will give your suggestion a try. To reproduce the issue you will need a transport returning multiple initial snapshots for your group subscription. Without that conditional I was referring to and with DQ strategy disabled crash will happen handling second snapshot from the group. -- Kind regards, Igor Kovalenko ____________________________________________________ Igor Kovalenko OOO "Deutsche Bank TechCentre" Global Technology Business Center Aquamarine, Ozerkovskaya naberezhnaya 24, 115184 Moscow, Russia Tel. +7 495 783-0313 Email igor.kovalenko@... toggle quoted messageShow quoted text From: Aaron Sneddon [mailto:asneddon@...] Sent: 18 декабря 2018 г. 17:06 To: Igor Kovalenko <igor.kovalenko@...>; Frank Quinn <fquinn@...>; openmama-dev@... Cc: Gary Molloy <gmolloy@...>; Philip McCausland <pmccausland@...> Subject: FW: [Openmama-dev] openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials Hey Igor, I find I am unable to reproduce your issue. I am using group subscriptions (to a feed handler) and have disabled dq. I tried the various config options to reproduce the issue (as there are transport specific and global config options for disabling dq strategy). With regards to the missing conditional: I can see that around the line of the change we have taken out the following conditional which I assume you are referring to: I would just point out that this conditional statement hasn’t been removed, but was relocated to mamaPlugin_fireSubscriptionPreMsgHook. Certainly, the return statement activated by that conditional now returns you to this function, from mamaPlugin_fireSubscriptionPreMsgHook. With previous functionality, this conditional would ensure you skip the code that you say causes the problem you are seeing, and that makes sense. I cannot recommend duplicating the conditional statement, as this would be unnecessary and as I cannot reproduce your issue I can only make a suggestion that hopefully you could try? At present mamaPlugin_fireSubscriptionPreMsgHook returns MAMA_STATUS_OK in all cases. My suggestion is, in dqstrategyplugin.c, at line 478, change MAMA_STATUS_OK to MAMA_STATUS_INVALID_ARG (for example). Then, in listenermsgcallback.c, on line 380, add in a check to the return type, and if you do not receive MAMA_STATUS_OK, return from this function. This would look like: if (MAMA_STATUS_OK != mamaPlugin_fireSubscriptionPreMsgHook(subscription, msgType, msg)) { return; } This would now emulate the previous functionality (but does not duplicate the conditional). I have done this myself and performed a quick check that it does not break anything and it looks fine. But as I say, I cannot replicate your issue and so cannot do a full check. I would therefore say that if it suits, you could change that single line in dqstrategyplugin.c and add the check in listenermsgcallback, and run a test to see if this fixes your issue. I am still concerned as to why I cannot reproduce the same issue, but please let me know what you think. Regards, Aaron From: Frank Quinn [mailto:fquinn@...] Sent: 11 December 2018 17:16 Cc: igor.kovalenko@...; Aaron Sneddon <asneddon@...>; openmama-dev <openmama-dev@...> Subject: Re: [Openmama-dev] openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials Aaron / Vela, could someone have a look please? On 12 Nov 2018 19:36, Frank Quinn <frank@...> wrote: Thanks Igor, This was part of Vela's DQ strategy changes - Aaron could you have a look please? Cheers, Frank On Mon, Nov 12, 2018 at 1:32 PM Igor Kovalenko <igor.kovalenko@...> wrote: Classification: Public Hi openmama team, I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c Now if group subscription, or in fact any allowing multiple initials, receives first initial, then - with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse - with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled. Hope it will be not hard to restore the conditional for openmama-6.2.x and later. Thank you! Kind regards, Igor Kovalenko -- --- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy. The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to this message and deleting it from your computer. Thank you. Vela Trading Systems LLC --- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.
More All Messages By This Member
Re: openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials Frank Quinn #2230 Aaron / Vela, could someone have a look please? toggle quoted messageShow quoted text On 12 Nov 2018 19:36, Frank Quinn <frank@...> wrote: Thanks Igor, This was part of Vela's DQ strategy changes - Aaron could you have a look please? Cheers, Frank On Mon, Nov 12, 2018 at 1:32 PM Igor Kovalenko <igor.kovalenko@...> wrote: Classification: Public Hi openmama team, I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c Now if group subscription, or in fact any allowing multiple initials, receives first initial, then - with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse - with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled. Hope it will be not hard to restore the conditional for openmama-6.2.x and later. Thank you! Kind regards, Igor Kovalenko -- --- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2229 Some changes have just been added to the origin/next branch! [noreply] Add cross platform docker builds (#388) release_scripts/install-dependencies.sh mama/c_cpp/src/c/dictionary.c .appveyor.yml common/c_cpp/src/gunittest/c/CMakeLists.txt release_scripts/ci-run.py mama/c_cpp/src/c/fielddesc.c common/c_cpp/src/gunittest/c/strutilstest.cpp mama/c_cpp/src/c/CMakeLists.txt cmake/FindAPR.cmake release_scripts/Dockerfile Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #245 Build Status: Successful Build Warnings: 0 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Still Failing) ci@... #2228 Some changes have just been added to the origin/next branch! [noreply] Add cross platform docker builds (#388) common/c_cpp/src/gunittest/c/strutilstest.cpp .appveyor.yml release_scripts/ci-run.py release_scripts/install-dependencies.sh mama/c_cpp/src/c/fielddesc.c cmake/FindAPR.cmake release_scripts/Dockerfile mama/c_cpp/src/c/CMakeLists.txt mama/c_cpp/src/c/dictionary.c common/c_cpp/src/gunittest/c/CMakeLists.txt Results for OpenMAMA_Snapshot_Windows CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Windows Build Number: #237 Build Status: Still Failing Build Warnings: Total Amount of Tests: Passed: Failed: Skipped / Disabled: You may also check CI console output to view the full results.
More All Messages By This Member
OpenMAMA_Snapshot_RPM - Build # 643 - Failure! ci@... #2227 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1474: getNumBidLevels and getNumAskLevels wrong on some occasions mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp Results for OpenMAMA_Snapshot_RPM CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_RPM Build Number: #643 Build Status: Failure Build Warnings: Total Amount of Tests: Passed: Failed: Skipped / Disabled: You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2226 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1474: getNumBidLevels and getNumAskLevels wrong on some occasions mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #244 Build Status: Successful Build Warnings: 0 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Still Failing) ci@... #2225 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1474: getNumBidLevels and getNumAskLevels wrong on some occasions mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp Results for OpenMAMA_Snapshot_Windows CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Windows Build Number: #236 Build Status: Still Failing Build Warnings: Total Amount of Tests: Passed: Failed: Skipped / Disabled: You may also check CI console output to view the full results.
More All Messages By This Member
Re: openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials Frank Quinn #2224 Thanks Igor, This was part of Vela's DQ strategy changes - Aaron could you have a look please? Cheers, Frank toggle quoted messageShow quoted text On Mon, Nov 12, 2018 at 1:32 PM Igor Kovalenko <igor.kovalenko@...> wrote: Classification: Public Hi openmama team, I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c Now if group subscription, or in fact any allowing multiple initials, receives first initial, then - with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse - with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled. Hope it will be not hard to restore the conditional for openmama-6.2.x and later. Thank you! Kind regards, Igor Kovalenko -- --- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.
More All Messages By This Member
openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials Igor Kovalenko #2223 Classification: Public Hi openmama team, I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c Now if group subscription, or in fact any allowing multiple initials, receives first initial, then - with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse - with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled. Hope it will be not hard to restore the conditional for openmama-6.2.x and later. Thank you! Kind regards, Igor Kovalenko -- --- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2222 Some changes have just been added to the origin/next branch! [noreply] Added initial docker files for performing builds (#385) mama/c_cpp/src/examples/c/CMakeLists.txt mama/CMakeLists.txt mama/c_cpp/src/testtools/performance/c/mamaconsumerc_v2.c mama/jni/src/CMakeLists.txt mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp mama/c_cpp/src/testtools/performance/c/CMakeLists.txt mama/c_cpp/src/testtools/performance/c/mamaproducerc_v2.c mamda/c_cpp/src/examples/orderbooks/CMakeLists.txt mamda/java/CMakeLists.txt release_scripts/install-dependencies.sh mama/c_cpp/src/testtools/performance/c/mamaconsumerc.c release_scripts/build-package.sh mama/c_cpp/src/examples/cpp/CMakeLists.txt .dockerignore mama/c_cpp/src/testtools/performance/c/mamaproducerc.c release_scripts/Dockerfile CMakeLists.txt cmake/mama-common.cmake mamda/c_cpp/src/examples/CMakeLists.txt Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #243 Build Status: Successful Build Warnings: 0 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Failure) ci@... #2221 Some changes have just been added to the origin/next branch! [noreply] Added initial docker files for performing builds (#385) mama/c_cpp/src/examples/c/CMakeLists.txt mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp CMakeLists.txt .dockerignore mamda/java/CMakeLists.txt mama/c_cpp/src/testtools/performance/c/mamaproducerc_v2.c mama/c_cpp/src/testtools/performance/c/mamaconsumerc.c mama/c_cpp/src/testtools/performance/c/CMakeLists.txt release_scripts/Dockerfile mama/c_cpp/src/testtools/performance/c/mamaproducerc.c cmake/mama-common.cmake mama/CMakeLists.txt mama/c_cpp/src/testtools/performance/c/mamaconsumerc_v2.c mamda/c_cpp/src/examples/orderbooks/CMakeLists.txt release_scripts/build-package.sh mama/c_cpp/src/examples/cpp/CMakeLists.txt mamda/c_cpp/src/examples/CMakeLists.txt mama/jni/src/CMakeLists.txt release_scripts/install-dependencies.sh Results for OpenMAMA_Snapshot_Windows CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Windows Build Number: #235 Build Status: Failure Build Warnings: Total Amount of Tests: Passed: Failed: Skipped / Disabled: You may also check CI console output to view the full results.
More All Messages By This Member
Changes to OpenMAMA CI / Pull Request Checks Frank Quinn #2220 Hi Folks, There were some compiler warnings that crept in recently in the MAMDA area that I didn't notice at code review time because travis / appveyor builds don't currently fail on warning. Instead, the warning is only reported when the PR is merged into next and the Jenkins CI environment picks it up. I've come back and cleaned these up myself as part of these changes. With this in mind I have made the following changes to the automatic PR code check systems: 1. I have retired travis. Appveyor now supports Ubuntu as well as Windows builds anyway (and more recent versions of Linux than Travis supports so you generally benefit from stricter gcc warnings). This means there's no longer any compelling reason to support both systems so I've turned travis off. 2. I have updated the build system to include -Werror so CI will now fail in the event of a compiler warning being produced. 3. Linux test builds now use cmake rather than scons. Note the next release will have scons removed so please try it out in your local builds. Note that I would have also modified valgrind to report on compiler warning but ubuntu looks like it currently reports errors that arent present on centos but that's a fight for another day, so I held fire on that one. Cheers, Frank -- Frank Quinn Cascadium T: +44 (0) 28 8678 8015 E: fquinn@... W: http://cascadium.io
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2219 Some changes have just been added to the origin/next branch! [noreply] Removed travis from build and added -Werror (#384) site_scons/community/windows.py mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp .appveyor.yml release_scripts/ci-run.py README.md mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp .travis.yml Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #242 Build Status: Successful Build Warnings: 0 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2218 Some changes have just been added to the origin/next branch! [fquinn.ni] Fixed issue with field names in sub msg mama/c_cpp/src/c/msg.c Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #241 Build Status: Successful Build Warnings: 1 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2217 Some changes have just been added to the origin/next branch! [fquinn.ni] Fixed warnings coming up from recent contributions mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBook.cpp mama/c_cpp/src/c/conflation/connection.c mama/c_cpp/src/c/transport.c common/c_cpp/src/c/linux/machine.c mama/c_cpp/src/c/playback/playbackpublisher.c mamda/c_cpp/src/cpp/orderbooks/MamdaBookAtomicListener.cpp mama/c_cpp/src/c/conflation/connection_int.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookEntry.cpp mamda/c_cpp/src/cpp/MamdaSubscription.cpp mama/c_cpp/src/examples/cpp/mamalistencpp.cpp mama/c_cpp/src/examples/cpp/mamalistencachedcpp.cpp mamda/c_cpp/src/cpp/MamdaQuoteListener.cpp Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #240 Build Status: Successful Build Warnings: 1 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2216 Some changes have just been added to the origin/next branch! [fquinn.ni] Added portable install rules for noop lib mama/c_cpp/src/c/entitlement/noop/CMakeLists.txt Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #239 Build Status: Successful Build Warnings: 8 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2215 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1441: Fix non-graceful shutdown of mamalistenc (#179) mama/c_cpp/src/examples/c/mamalistenc.c [fquinn.ni] PLAT-1442: add new parameter to write output to file in mamalistenc mama/c_cpp/src/examples/c/mamalistenc.c Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #238 Build Status: Successful Build Warnings: 8 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2214 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1423 open file with binary flag (#178) mama/c_cpp/src/c/playback/playbackcapture.c Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #237 Build Status: Successful Build Warnings: 8 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2213 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1449: Mamda app includes phantom bid (#177) mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #236 Build Status: Successful Build Warnings: 8 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member
Code change(s) just landed on origin/next (Successful) ci@... #2212 Some changes have just been added to the origin/next branch! [fquinn.ni] PLAT-1453: MamaFieldCache::find( ) method seems to exhibit static ret… mama/c_cpp/src/cpp/mama/fieldcache/MamaFieldCache.h Results for OpenMAMA_Snapshot_Linux CI run with latest changes: CI Project Name: OpenMAMA_Snapshot_Linux Build Number: #235 Build Status: Successful Build Warnings: 7 Total Amount of Tests: 1858 Passed: 1858 Failed: 0 Skipped / Disabled: 0 You may also check CI console output to view the full results.
More All Messages By This Member

81 - 100 of 2311

Home Hashtags Subgroups Terms