Changes to OpenMAMA CI / Pull Request Checks
Frank Quinn
Hi Folks,
There were some compiler warnings that crept in recently in the MAMDA area that I didn't notice at code review time because travis / appveyor builds don't currently fail on warning. Instead, the warning is only reported when the PR is merged into next
and the Jenkins CI environment picks it up. I've come back and cleaned these up myself as part of these changes.
With this in mind I have made the following changes to the automatic PR code check systems:
1. I have retired travis. Appveyor now supports Ubuntu as well as Windows builds anyway (and more recent versions of Linux than Travis supports so you generally benefit from stricter gcc warnings). This means there's no longer any compelling reason to
support both systems so I've turned travis off.
2. I have updated the build system to include -Werror so CI will now fail in the event of a compiler warning being produced.
3. Linux test builds now use cmake rather than scons. Note the next release will have scons removed so please try it out in your local builds.
Note that I would have also modified valgrind to report on compiler warning but ubuntu looks like it currently reports errors that arent present on centos but that's a fight for another day, so I held fire on that one.
Cheers,
Frank
--
Frank Quinn
Cascadium
T: +44 (0) 28 8678 8015
E: fquinn@...
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[noreply] Removed travis from build and added -Werror (#384) site_scons/community/windows.py mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp .appveyor.yml release_scripts/ci-run.py README.md mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp .travis.yml
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Fixed issue with field names in sub msg mama/c_cpp/src/c/msg.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Fixed warnings coming up from recent contributions mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBook.cpp mama/c_cpp/src/c/conflation/connection.c mama/c_cpp/src/c/transport.c common/c_cpp/src/c/linux/machine.c mama/c_cpp/src/c/playback/playbackpublisher.c mamda/c_cpp/src/cpp/orderbooks/MamdaBookAtomicListener.cpp mama/c_cpp/src/c/conflation/connection_int.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookEntry.cpp mamda/c_cpp/src/cpp/MamdaSubscription.cpp mama/c_cpp/src/examples/cpp/mamalistencpp.cpp mama/c_cpp/src/examples/cpp/mamalistencachedcpp.cpp mamda/c_cpp/src/cpp/MamdaQuoteListener.cpp
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added portable install rules for noop lib mama/c_cpp/src/c/entitlement/noop/CMakeLists.txt
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] PLAT-1441: Fix non-graceful shutdown of mamalistenc (#179) mama/c_cpp/src/examples/c/mamalistenc.c [fquinn.ni] PLAT-1442: add new parameter to write output to file in mamalistenc mama/c_cpp/src/examples/c/mamalistenc.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] PLAT-1423 open file with binary flag (#178) mama/c_cpp/src/c/playback/playbackcapture.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] PLAT-1449: Mamda app includes phantom bid (#177) mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] PLAT-1453: MamaFieldCache::find( ) method seems to exhibit static ret… mama/c_cpp/src/cpp/mama/fieldcache/MamaFieldCache.h
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
ci@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] fix mamapublisherc SEGV on exit mama/c_cpp/src/examples/c/mamapublisherc.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Fixed)
ci@...
Some changes have just been added to the origin/next branch!
[Frank Quinn] Fixed issue with serializing vectors to json mama/c_cpp/src/c/msg.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Unstable)
ci@...
Some changes have just been added to the origin/next branch!
[Frank Quinn] Added mamaMsg_toJsonStringWithDictionary method mama/c_cpp/src/c/msg.c mama/c_cpp/src/c/mama/msg.h
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
jenkins@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Get rid of vectors in MAMA public headers mama/c_cpp/src/cpp/MamaMsg.cpp mama/c_cpp/src/cpp/mama/MamaMsgField.h mama/c_cpp/src/cpp/mama/mamacpp.h mama/c_cpp/src/examples/cpp/mamasymbollistsubscribercpp.cpp mamda/c_cpp/src/cpp/mamda/MamdaSubscription.h mama/c_cpp/src/cpp/mama/fieldcache/MamaFieldCache.h mama/c_cpp/src/cpp/mamacpp.cpp [fquinn.ni] Some headers were not installed mama/c_cpp/src/c/dqstrategyplugin/CMakeLists.txt common/c_cpp/src/c/CMakeLists.txt mamda/c_cpp/src/cpp/options/CMakeLists.txt mamda/c_cpp/src/cpp/news/CMakeLists.txt mamda/c_cpp/src/cpp/orderbooks/CMakeLists.txt [fquinn.ni] Option to generate and install Javadocs mama/jni/build.gradle mamda/java/build.gradle mamda/c_cpp/SConscript CMakeLists.txt mamda/java/CMakeLists.txt mama/c_cpp/SConscript mama/jni/src/CMakeLists.txt
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
jenkins@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] PLAT-1356-3 (#167) mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookBasicDelta.cpp mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookEntry.cpp mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp mamda/c_cpp/src/cpp/orderbooks/MamdaBookAtomicListener.cpp mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookConcreteComplexDelta.cpp mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookWriter.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookBasicDeltaList.h mamda/c_cpp/src/examples/orderbooks/atomicbookbuilder.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaBookAtomicLevelEntry.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookFields.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookEntry.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookBasicDeltaList.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaBookAtomicListener.h mamda/c_cpp/src/examples/orderbooks/bookticker.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookBasicDelta.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBook.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookFields.h mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBook.h mamda/c_cpp/src/examples/orderbooks/atomicbookticker.cpp mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookPriceLevel.h [fquinn.ni] PLAT 1459 (#174) mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp [fquinn.ni] Used correct addentry, and guarded updateentryposition (#173) mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp [fquinn.ni] Java QAP changes mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookPriceLevel.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookWriter.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookEntry.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookFields.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookListener.java mamda/java/src/main/java/com/wombat/mamda/examples/MamdaBookTicker.java [fquinn.ni] Whitespace mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookListener.java
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
OpenMAMA 6.2.3 Released
Frank Quinn
Hi Folks,
We are pleased to announce the final release of OpenMAMA 6.2.3 is now available:
https://github.com/OpenMAMA/OpenMAMA/releases/tag/OpenMAMA-6.2.3-release
This is a hotfix release to address two key issues which were discovered as part of the recent 6.2.2 release:
* Restore mamaSubscription RecoverGaps functions accidentally removed in the last release * Restore missing wombat portability headers in 6.2.2 Release
For a complete list of the issues included in this release, please see here: https://github.com/OpenMAMA/OpenMAMA/milestone/9?closed=1
Cheers, Frank
Frank Quinn Cascadium T: +44 (0) 28 8678 8015 E: fquinn@...
|
|
Code change just landed on origin/master (Successful)
jenkins@...
Some changes have just been added to the origin/master branch!
[fquinn.ni] Build oea and noop bridges when configured mama/CMakeLists.txt CMakeLists.txt mama/c_cpp/src/c/CMakeLists.txt mama/c_cpp/src/c/entitlement/oea/CMakeLists.txt [fquinn.ni] Fix for Issue #371 common/c_cpp/src/c/SConscript [Frank Quinn] Updated version information to 6.2.2 mama/dotnet/src/cs/MamaVersion.cs mama/VERSION.scons mama/jni/build.xml mama/c_cpp/src/c/generateMamaSourceFiles.bat mamda/java/build.xml mamda/VERSION.scons mamda/c_cpp/src/cpp/generateMamdaVersion.bat [noreply] Fixed typo in MamaVersion C# mama/dotnet/src/cs/MamaVersion.cs [fquinn.ni] Restored mamaSubscription_setRecoverGaps and mama/c_cpp/src/c/subscription.c mama/c_cpp/src/c/mama/subscription.h [fquinn.ni] Added maven central tasks and fixed javadoc error mama/jni/src/main/java/com/wombat/mama/examples/MamaListen.java mama/jni/src/main/java/com/wombat/mama/MamaDateTime.java mama/jni/gradle.properties mamda/java/src/main/java/com/wombat/mamda/MamdaTradeRecap.java mamda/java/src/main/java/com/wombat/mamda/MamdaQuoteUpdate.java mamda/java/gradle.properties mamda/java/src/main/java/com/wombat/mamda/MamdaSecurityStatus.java mamda/java/src/main/java/com/wombat/mamda/MamdaTradeCancelOrError.java mamda/java/src/main/java/com/wombat/mamda/examples/MamdaBookTicker.java mamda/java/src/main/java/com/wombat/mamda/MamdaOrderImbalanceListener.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBook.java mamda/java/src/main/java/com/wombat/mamda/MamdaTradeListener.java mamda/java/src/main/java/com/wombat/mamda/MamdaFields.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookEntry.java mama/jni/build.gradle mama/jni/src/main/java/com/wombat/mama/MamaPrice.java mamda/java/src/main/java/com/wombat/mamda/MamdaAuctionListener.java mama/jni/src/main/java/com/wombat/mama/MamaMsg.java mamda/java/src/main/java/com/wombat/mamda/MamdaConcreteBasicEvent.java mamda/java/build.gradle mamda/java/src/main/java/com/wombat/mamda/MamdaTradeCorrection.java mamda/java/src/main/java/com/wombat/mamda/MamdaTradeReport.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookPriceLevel.java mama/jni/src/main/java/com/wombat/mama/MamaError.java mamda/java/src/main/java/com/wombat/mamda/MamdaSecurityStatusUpdate.java mama/jni/src/main/java/com/wombat/mama/MamaPricePrecision.java [fquinn.ni] Updating versions for maven upload mama/jni/build.gradle mamda/java/build.gradle [fquinn.ni] Updated cmake not to use maven central naming mama/jni/src/CMakeLists.txt mamda/java/CMakeLists.txt mama/jni/build.gradle mamda/java/build.gradle [Frank Quinn] Updated version information to 6.2.3 mama/dotnet/src/cs/MamaVersion.cs mama/VERSION.scons mamda/VERSION.scons mamda/java/build.xml mama/c_cpp/src/c/generateMamaSourceFiles.bat mamda/c_cpp/src/cpp/generateMamdaVersion.bat mama/jni/build.xml
Results for OpenMAMA_Stable_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
OpenMAMA 6.2.3-rc1 Release (Hotfix)
Frank Quinn
Hi Folks,
Following the release of 6.2.2, two significant issues have been spotted which required hotfixes:
· The portability headers (e.g. port.h) were missing from the scons generated packages (linux only) · The OpenMAMA methods mamaSubscription_getRecoverGaps and mamaSubscription_setRecoverGaps were accidentally removed as part of the recent DQ strategy changes. These are rarely used, but are public methods nevertheless and should be treated as such.
Fixes for these have been contributed by Solace with thanks and I have cut a new 6.2.3 release candidate which you can grab here:
https://github.com/OpenMAMA/OpenMAMA/releases/tag/OpenMAMA-6.2.3-rc1
I'd like to take this opportunity to remind everyone that the RC window is the best opportunity to test any bridges and applications without risk before drifting into hotfix territory so please bear this in mind going forward.
Since this is a small release in terms of features, I'll run a short RC window until the end of the week which will be reviewed if new issues are found. This makes the expected release date to be 3rd August 2018.
As usual if you have any questions, please reply to this thread.
Cheers, Frank
Frank Quinn Cascadium T: +44 (0) 28 8678 8015 E: fquinn@...
|
|
Code change(s) just landed on origin/next (Successful)
jenkins@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added maven central tasks and fixed javadoc error mamda/java/src/main/java/com/wombat/mamda/MamdaConcreteBasicEvent.java mamda/java/src/main/java/com/wombat/mamda/MamdaSecurityStatusUpdate.java mama/jni/src/main/java/com/wombat/mama/MamaMsg.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookPriceLevel.java mama/jni/src/main/java/com/wombat/mama/examples/MamaListen.java mamda/java/build.gradle mamda/java/src/main/java/com/wombat/mamda/MamdaTradeRecap.java mamda/java/src/main/java/com/wombat/mamda/MamdaAuctionListener.java mamda/java/src/main/java/com/wombat/mamda/MamdaQuoteUpdate.java mamda/java/src/main/java/com/wombat/mamda/MamdaTradeListener.java mama/jni/src/main/java/com/wombat/mama/MamaPricePrecision.java mama/jni/src/main/java/com/wombat/mama/MamaPrice.java mamda/java/gradle.properties mamda/java/src/main/java/com/wombat/mamda/MamdaFields.java mamda/java/src/main/java/com/wombat/mamda/MamdaSecurityStatus.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookEntry.java mama/jni/src/main/java/com/wombat/mama/MamaDateTime.java mamda/java/src/main/java/com/wombat/mamda/MamdaOrderImbalanceListener.java mama/jni/src/main/java/com/wombat/mama/MamaError.java mama/jni/build.gradle mamda/java/src/main/java/com/wombat/mamda/MamdaTradeReport.java mamda/java/src/main/java/com/wombat/mamda/MamdaTradeCorrection.java mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBook.java mama/jni/gradle.properties mamda/java/src/main/java/com/wombat/mamda/MamdaTradeCancelOrError.java mamda/java/src/main/java/com/wombat/mamda/examples/MamdaBookTicker.java [fquinn.ni] Updating versions for maven upload mama/jni/build.gradle mamda/java/build.gradle [fquinn.ni] Updated cmake not to use maven central naming mama/jni/src/CMakeLists.txt mamda/java/CMakeLists.txt mamda/java/build.gradle mama/jni/build.gradle
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
jenkins@...
Some changes have just been added to the origin/next branch!
[fquinn.ni] Restored mamaSubscription_setRecoverGaps and mama/c_cpp/src/c/mama/subscription.h mama/c_cpp/src/c/subscription.c
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|
Code change(s) just landed on origin/next (Successful)
jenkins@...
Some changes have just been added to the origin/next branch!
[noreply] Fixed typo in MamaVersion C# mama/dotnet/src/cs/MamaVersion.cs
Results for OpenMAMA_Snapshot_Linux CI run with latest changes:
You may also check CI console output to view the full results.
|
|