|
Re: [PATCH 2.3.1] Wombat: Add wombatQueue_deallocate
Cheers for this Sam.
At a quick look the code all looks reasonable. Have you performed any
testing around the changes? It seems like a good candidate for some unit
tests - most likely within the
Cheers for this Sam.
At a quick look the code all looks reasonable. Have you performed any
testing around the changes? It seems like a good candidate for some unit
tests - most likely within the
|
By
Damian Maguire <d.maguire@...>
·
#1377
·
|
|
[PATCH 2.3.1] Wombat: Add wombatQueue_deallocate
Hey,
Here is a patch that adds wombatQueue_deallocate, which makes it
possible to reclaim resources if wombatQueue_create fails.
Cheers,
Sam
diff --git a/common/c_cpp/src/c/queue.c
Hey,
Here is a patch that adds wombatQueue_deallocate, which makes it
possible to reclaim resources if wombatQueue_create fails.
Cheers,
Sam
diff --git a/common/c_cpp/src/c/queue.c
|
By
Sam Wilson <Sam.Wilson@...>
·
#1376
·
|
|
Re: VectorChar and VectorBool field type enumerator
Awesome, looks really great Alireza. I'll take a look through the patches attached to the Bugzilla and provide any feedback there.
Obviously you've put a lot of effort into the testing here, really
Awesome, looks really great Alireza. I'll take a look through the patches attached to the Bugzilla and provide any feedback there.
Obviously you've put a lot of effort into the testing here, really
|
By
Damian Maguire
·
#1374
·
|
|
Re: Wombat Queue Destroy
Hey Sam,
Personally I would be inclined towards the addition of wombatQueue_deallocate, and then having this called within the context of the existing wombatQueue_destroy. This would result in no
Hey Sam,
Personally I would be inclined towards the addition of wombatQueue_deallocate, and then having this called within the context of the existing wombatQueue_destroy. This would result in no
|
By
Damian Maguire
·
#1373
·
|
|
Re: [PATCH 2.3.1] MamaPublisher: Overloaded MamaPublisher create method
Thanks Chad, we'll take a look.
D
On 28/10/14 19:43, Meyer, Chad J wrote:
Thanks Chad, we'll take a look.
D
On 28/10/14 19:43, Meyer, Chad J wrote:
|
By
Damian Maguire <d.maguire@...>
·
#1375
·
|
|
Re: [PATCH 2.3.1] MamaPublisher: Overloaded MamaPublisher create method
Hi Damian,
I have attached a patch in the bugzilla ticket containing a new JUnit test case for testing the new create method.
Regards,
Chad Meyer|Corporate & Investment Bank | PIM Market
Hi Damian,
I have attached a patch in the bugzilla ticket containing a new JUnit test case for testing the new create method.
Regards,
Chad Meyer|Corporate & Investment Bank | PIM Market
|
By
Chad Meyer
·
#1372
·
|
|
Re: Wombat Queue Destroy
Hey Damian,
I'm just getting around to looking at this now. Would you prefer a patch that addswombatQueue_deallocate, or one that merges both wombatQueue_allocate andwombatQueue_create into
Hey Damian,
I'm just getting around to looking at this now. Would you prefer a patch that addswombatQueue_deallocate, or one that merges both wombatQueue_allocate andwombatQueue_create into
|
By
Sam Wilson <Sam.Wilson@...>
·
#1371
·
|
|
Re: VectorChar and VectorBool field type enumerator
Hi Damian,
I have raised Bugzilla ticket 168 (http://bugs.openmama.org/show_bug.cgi?id=168) and provided a patch to address this for C/C++ for the first stage.
Thanks.
--Alireza
From:
Hi Damian,
I have raised Bugzilla ticket 168 (http://bugs.openmama.org/show_bug.cgi?id=168) and provided a patch to address this for C/C++ for the first stage.
Thanks.
--Alireza
From:
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1370
·
|
|
[PATCH 2.3.1 5/5] MAMA: Update examples and test tools for completed support of Vector Bool and Vectar Char.
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
mama/c_cpp/src/examples/c/mamalistencachedc.c | 26 ++++++++++++++
.../c_cpp/src/examples/cpp/mamalistencachedcpp.cpp
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
mama/c_cpp/src/examples/c/mamalistencachedc.c | 26 ++++++++++++++
.../c_cpp/src/examples/cpp/mamalistencachedcpp.cpp
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1368
·
|
|
[PATCH 2.3.1 4/5] MAMA: Update gunittest for completed support of Vector Bool and Vectar Char.
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
.../gunittest/c/fieldcache/fieldcachefieldtest.cpp | 60 ++++++++++++++++
.../gunittest/c/mamamsg/msgfieldvectortests.cpp
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
.../gunittest/c/fieldcache/fieldcachefieldtest.cpp | 60 ++++++++++++++++
.../gunittest/c/mamamsg/msgfieldvectortests.cpp
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1367
·
|
|
[PATCH 2.3.1 3/5] QPID: Add support for Vector Bool and Vector Char field types.
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
mama/c_cpp/src/c/payload/qpidmsg/field.c | 12 +++++++++++-
mama/c_cpp/src/c/payload/qpidmsg/payload.c | 20
Signed-off-by: Alireza Assadzadeh <Alireza.Assadzadeh@...>
---
mama/c_cpp/src/c/payload/qpidmsg/field.c | 12 +++++++++++-
mama/c_cpp/src/c/payload/qpidmsg/payload.c | 20
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1366
·
|
|
[PATCH 2.3.1 2/5] MAMACPP: Complete support of Vector Bool and Vector Char field types.
Update MAMACPP for Mama message field, cache field, and cache field
types to complete support of Vector Bool and Vector Char.
Signed-off-by: Alireza Assadzadeh
Update MAMACPP for Mama message field, cache field, and cache field
types to complete support of Vector Bool and Vector Char.
Signed-off-by: Alireza Assadzadeh
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1365
·
|
|
[PATCH 2.3.1 1/5] MAMAC: Complete support of Vector Bool and Vector Char field types.
Add enumerator for Vector Bool and Vector Char for mamaFieldType and
complete the corresponding changes in MAMAC for using these two types.
Signed-off-by: Alireza Assadzadeh
Add enumerator for Vector Bool and Vector Char for mamaFieldType and
complete the corresponding changes in MAMAC for using these two types.
Signed-off-by: Alireza Assadzadeh
|
By
Alireza Assadzadeh <Alireza.Assadzadeh@...>
·
#1369
·
|
|
Possible bug with MamaSubscription.java
Hi,
I’ve been testing the setupSubscription and createSubscription methods found in MamaSubscription.java. Key difference between the two is that setupSubscription is used when a subscription is
Hi,
I’ve been testing the setupSubscription and createSubscription methods found in MamaSubscription.java. Key difference between the two is that setupSubscription is used when a subscription is
|
By
Chad Meyer
·
#1364
·
|
|
Re: [PATCH 2.3.1] MamaPublisher: Overloaded MamaPublisher create method
Thanks for the ping Chad, I'll get looking at this as soon as I can and let you know if we have any questions.
Cheers,
Damian
On 23/10/14 15:10, Meyer, Chad J wrote:
Thanks for the ping Chad, I'll get looking at this as soon as I can and let you know if we have any questions.
Cheers,
Damian
On 23/10/14 15:10, Meyer, Chad J wrote:
|
By
Damian Maguire <d.maguire@...>
·
#1363
·
|
|
Re: [PATCH 2.3.1] MamaPublisher: Overloaded MamaPublisher create method
Hi Damian,
Added comments about a week ago to the Bugzilla ticket referenced below regarding what I did for testing. Please let me know if you need more evidence of testing.
Regards,
Chad
Hi Damian,
Added comments about a week ago to the Bugzilla ticket referenced below regarding what I did for testing. Please let me know if you need more evidence of testing.
Regards,
Chad
|
By
Chad Meyer
·
#1362
·
|
|
Re: Mama reserved fields as two struct types
Hi Reed,
This difference appears for historical reasons. A lot of the fields that are not available as field descriptors are no longer used within the platform e.g. MdRvSyncPattern
Can you raise
Hi Reed,
This difference appears for historical reasons. A lot of the fields that are not available as field descriptors are no longer used within the platform e.g. MdRvSyncPattern
Can you raise
|
By
Ian Bell <IBell@...>
·
#1361
·
|
|
Re: [PATCH 2.3.1] wombat: make wInterlocked_set consistent
Cheers for the patch Sam, looks good. Can you raise this in bugzilla
(bugs.openmama.org) as well, and we can track getting it into next
there?
Thanks,
Cheers for the patch Sam, looks good. Can you raise this in bugzilla
(bugs.openmama.org) as well, and we can track getting it into next
there?
Thanks,
|
By
Damian Maguire <DMaguire@...>
·
#1360
·
|
|
[PATCH 2.3.1] wombat: make wInterlocked_set consistent
Hey,
Attached is a patch to make wInterlocked_set consistent between Windows
and Linux. The previous behaviour on Windows was to return the prior
value of the interlocked int, while on Linux the
Hey,
Attached is a patch to make wInterlocked_set consistent between Windows
and Linux. The previous behaviour on Windows was to return the prior
value of the interlocked int, while on Linux the
|
By
Sam Wilson <Sam.Wilson@...>
·
#1359
·
|
|
Re: [PATCH 2.3.1] MamaPublisher: Overloaded MamaPublisher create method
Hey Chad,
I was just taking a look over this again, and decided that I'd stick it into Bugzilla to keep track of it there. If you'd like to sign up for an account you can add yourself as a CC to
Hey Chad,
I was just taking a look over this again, and decided that I'd stick it into Bugzilla to keep track of it there. If you'd like to sign up for an account you can add yourself as a CC to
|
By
Damian Maguire
·
#1358
·
|