|
Re: Finalizers are dangerous
Hi Frank:
Obviously I would prefer to remain as close as possible to upstream code, so forking is a last resort. That being said, you’ve been so far quite unreceptive to my concerns about crashing
Hi Frank:
Obviously I would prefer to remain as close as possible to upstream code, so forking is a last resort. That being said, you’ve been so far quite unreceptive to my concerns about crashing
|
By
Bill Torpey
·
#2137
·
|
|
Re: Finalizers are dangerous
On the contrary I welcome OpenMAMA forks If you want to fork and maintain all fixes etc from the upstream that's entirely your decision and part of the beauty of Open Source software. More power to
On the contrary I welcome OpenMAMA forks If you want to fork and maintain all fixes etc from the upstream that's entirely your decision and part of the beauty of Open Source software. More power to
|
By
Frank Quinn
·
#2136
·
|
|
Re: Finalizers are dangerous
See comments inline …
No, we shut down the bridges to prevent events from firing. In some cases (and certainly *not* all) that also releases resources acquired when the bridges were opened, which
See comments inline …
No, we shut down the bridges to prevent events from firing. In some cases (and certainly *not* all) that also releases resources acquired when the bridges were opened, which
|
By
Bill Torpey
·
#2135
·
|
|
Re: Finalizers are dangerous
@Yury: The short answer is that we can't, but we can check if a bridge is still open before attempting to access bridge dependant methods in finalisers / destructors which was my suggestion.
@Yury: The short answer is that we can't, but we can check if a bridge is still open before attempting to access bridge dependant methods in finalisers / destructors which was my suggestion.
|
By
Frank Quinn
·
#2134
·
|
|
Re: Finalizers are dangerous
Hi Bill,
We close the bridges because we leak memory if we dont. Imho leaking memory should be avoided where possible. In this case, its avoidable, so I don't think we should do it.
If you really want
Hi Bill,
We close the bridges because we leak memory if we dont. Imho leaking memory should be avoided where possible. In this case, its avoidable, so I don't think we should do it.
If you really want
|
By
Frank Quinn
·
#2133
·
|
|
Re: Finalizers are dangerous
Classification: Public
Hi Frank,
> I would suggest a similar approach in Java - let the language specific layer deal with the language specific nuances.
What is the idea on how to avoid this
Classification: Public
Hi Frank,
> I would suggest a similar approach in Java - let the language specific layer deal with the language specific nuances.
What is the idea on how to avoid this
|
By
Yury Batrakov
·
#2132
·
|
|
Re: Finalizers are dangerous
HI Frank:
And Happy Holidays to you too!
A couple of points:
I’m not aware of any changes to OpenMAMA that affect the issue, so if there are some please point me in the proper direction. The last
HI Frank:
And Happy Holidays to you too!
A couple of points:
I’m not aware of any changes to OpenMAMA that affect the issue, so if there are some please point me in the proper direction. The last
|
By
Bill Torpey
·
#2131
·
|
|
Re: Finalizers are dangerous
Classification: Public
It is possible to group all mama objects (transports, subscriptions...) in one class and let it's destructor to delete them in required order. Obviously this class shouldn't let
Classification: Public
It is possible to group all mama objects (transports, subscriptions...) in one class and let it's destructor to delete them in required order. Obviously this class shouldn't let
|
By
Yury Batrakov
·
#2129
·
|
|
Re: Finalizers are dangerous
Not sure about the other alternative?
Are you expecting OpenMAMA C-API to keep track of all GC objects like shared_ptr ?
*(Keeping a table of active objects for clean-up at Mama.close() may also add
Not sure about the other alternative?
Are you expecting OpenMAMA C-API to keep track of all GC objects like shared_ptr ?
*(Keeping a table of active objects for clean-up at Mama.close() may also add
|
By
Sanjeev Wahi
·
#2130
·
|
|
Re: Finalizers are dangerous
Happy holidays folks!
First of all (with respect to the C++ concerns), that ticket is still open - I plan on actioning it I just haven't had time yet.
My suggestions were far from "don't solve it" and
Happy holidays folks!
First of all (with respect to the C++ concerns), that ticket is still open - I plan on actioning it I just haven't had time yet.
My suggestions were far from "don't solve it" and
|
By
Frank Quinn
·
#2128
·
|
|
Re: Finalizers are dangerous
Sanjeev:
Thanks for the suggestion, but that is basically doing C-style manual memory management. That’s not a direction I’m interested in going — it’s the 21st century, and OpenMAMA needs
Sanjeev:
Thanks for the suggestion, but that is basically doing C-style manual memory management. That’s not a direction I’m interested in going — it’s the 21st century, and OpenMAMA needs
|
By
Bill Torpey
·
#2127
·
|
|
Re: Finalizers are dangerous
I can suggest a possible fix (by adding extra weak_ptr check) while calling Mama.close() that can avoid this problem in C11/C11++ when using shared_ptr.
*(assumption is Mama.close() is not called by
I can suggest a possible fix (by adding extra weak_ptr check) while calling Mama.close() that can avoid this problem in C11/C11++ when using shared_ptr.
*(assumption is Mama.close() is not called by
|
By
Sanjeev Wahi
·
#2126
·
|
|
Re: Finalizers are dangerous
Unfortunately, that is not a bug, but a “feature”.
The problem is that mama_close unloads both the transport and payload libraries (via dlclose on Linux). So, any access to any objects related
Unfortunately, that is not a bug, but a “feature”.
The problem is that mama_close unloads both the transport and payload libraries (via dlclose on Linux). So, any access to any objects related
|
By
Bill Torpey
·
#2125
·
|
|
Finalizers are dangerous
Classification: Public
Hi team,
Sorry for telling bad news in holidays but I have found a major issue with Java API - JVM may crash if GC comes after Mama.close() method. Here's code sample to
Classification: Public
Hi team,
Sorry for telling bad news in holidays but I have found a major issue with Java API - JVM may crash if GC comes after Mama.close() method. Here's code sample to
|
By
Yury Batrakov
·
#2124
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[noreply] Added vcpkg_build option for use with vcpkg
Some changes have just been added to the origin/next branch!
[noreply] Added vcpkg_build option for use with vcpkg
|
By
jenkins@...
·
#2123
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added new option for disabling runtime
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added new option for disabling runtime
|
By
jenkins@...
·
#2122
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[noreply] Added visual studio 14.1 as build option site_scons/community/command_line.py
Results for OpenMAMA_Snapshot_Linux CI run with
Some changes have just been added to the origin/next branch!
[noreply] Added visual studio 14.1 as build option site_scons/community/command_line.py
Results for OpenMAMA_Snapshot_Linux CI run with
|
By
jenkins@...
·
#2121
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[fquinn.ni] [MAMDA] Removing duplicated FieldUpdate structs mamda/c_cpp/src/cpp/MamdaTradeListener.cpp
Results for
Some changes have just been added to the origin/next branch!
[fquinn.ni] [MAMDA] Removing duplicated FieldUpdate structs mamda/c_cpp/src/cpp/MamdaTradeListener.cpp
Results for
|
By
jenkins@...
·
#2120
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added lex option to allow optional tool
Some changes have just been added to the origin/next branch!
[fquinn.ni] Added lex option to allow optional tool
|
By
jenkins@...
·
#2119
·
|
|
Code change(s) just landed on origin/next (Successful)
Some changes have just been added to the origin/next branch!
[fquinn.ni] [COMMON] Enhancements to support
Some changes have just been added to the origin/next branch!
[fquinn.ni] [COMMON] Enhancements to support
|
By
jenkins@...
·
#2118
·
|