Date   

Code change(s) just landed on origin/next (Still Failing)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1474: getNumBidLevels and getNumAskLevels wrong on some occasions
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp


Results for OpenMAMA_Snapshot_Windows CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Windows
  • Build Number: #236
  • Build Status: Still Failing
  • Build Warnings:
  • Total Amount of Tests:
  • Passed:
  • Failed:
  • Skipped / Disabled:

You may also check CI console output to view the full results.


Re: openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials

Frank Quinn
 

Thanks Igor,

This was part of Vela's DQ strategy changes - Aaron could you have a look please?

Cheers,
Frank

On Mon, Nov 12, 2018 at 1:32 PM Igor Kovalenko <igor.kovalenko@...> wrote:

Classification: Public

Hi openmama team,

 

I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c

 

Now if group subscription, or in fact any allowing multiple initials, receives first initial, then

- with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse

- with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false

 

The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled.

 

Hope it will be not hard to restore the conditional for openmama-6.2.x and later.

 

Thank you!

 

Kind regards,

Igor Kovalenko

 

--

 



---
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.


openmama 6.2 crash with dqstrategy disabled for subscription with multiple initials

Igor Kovalenko
 

Classification: Public

Hi openmama team,

 

I see that commit 6de60350f40b4d9b0f181b7e64e0d192798b9f97 accidentally removed one conditional expression from around current line 393 of listenermsgcallbacks.c

 

Now if group subscription, or in fact any allowing multiple initials, receives first initial, then

- with dqstrategy disabled listenerMsgCallback_processMsg will unconditionally call mamaSubscription_stopWaitForResponse

- with dqstrategy enabled dqstrategy plugin implementation would only call mamaSubscription_stopWaitForResponse if mamaSubscription_getAcceptMultipleInitials() returns false

 

The code that stops waiting for response destroys related inbox object. This leads to easy crash with group subscriptions and dqstrategy disabled.

 

Hope it will be not hard to restore the conditional for openmama-6.2.x and later.

 

Thank you!

 

Kind regards,

Igor Kovalenko

 

--

 



---
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

Please refer to https://www.db.com/disclosures for additional EU corporate and regulatory disclosures and to http://www.db.com/unitedkingdom/content/privacy.htm for information about privacy.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[noreply] Added initial docker files for performing builds (#385)
	mama/c_cpp/src/examples/c/CMakeLists.txt
	mama/CMakeLists.txt
	mama/c_cpp/src/testtools/performance/c/mamaconsumerc_v2.c
	mama/jni/src/CMakeLists.txt
	mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp
	mama/c_cpp/src/testtools/performance/c/CMakeLists.txt
	mama/c_cpp/src/testtools/performance/c/mamaproducerc_v2.c
	mamda/c_cpp/src/examples/orderbooks/CMakeLists.txt
	mamda/java/CMakeLists.txt
	release_scripts/install-dependencies.sh
	mama/c_cpp/src/testtools/performance/c/mamaconsumerc.c
	release_scripts/build-package.sh
	mama/c_cpp/src/examples/cpp/CMakeLists.txt
	.dockerignore
	mama/c_cpp/src/testtools/performance/c/mamaproducerc.c
	release_scripts/Dockerfile
	CMakeLists.txt
	cmake/mama-common.cmake
	mamda/c_cpp/src/examples/CMakeLists.txt


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #243
  • Build Status: Successful
  • Build Warnings: 0
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Failure)

ci@...
 

Some changes have just been added to the origin/next branch!

[noreply] Added initial docker files for performing builds (#385)
	mama/c_cpp/src/examples/c/CMakeLists.txt
	mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp
	CMakeLists.txt
	.dockerignore
	mamda/java/CMakeLists.txt
	mama/c_cpp/src/testtools/performance/c/mamaproducerc_v2.c
	mama/c_cpp/src/testtools/performance/c/mamaconsumerc.c
	mama/c_cpp/src/testtools/performance/c/CMakeLists.txt
	release_scripts/Dockerfile
	mama/c_cpp/src/testtools/performance/c/mamaproducerc.c
	cmake/mama-common.cmake
	mama/CMakeLists.txt
	mama/c_cpp/src/testtools/performance/c/mamaconsumerc_v2.c
	mamda/c_cpp/src/examples/orderbooks/CMakeLists.txt
	release_scripts/build-package.sh
	mama/c_cpp/src/examples/cpp/CMakeLists.txt
	mamda/c_cpp/src/examples/CMakeLists.txt
	mama/jni/src/CMakeLists.txt
	release_scripts/install-dependencies.sh


Results for OpenMAMA_Snapshot_Windows CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Windows
  • Build Number: #235
  • Build Status: Failure
  • Build Warnings:
  • Total Amount of Tests:
  • Passed:
  • Failed:
  • Skipped / Disabled:

You may also check CI console output to view the full results.


Changes to OpenMAMA CI / Pull Request Checks

Frank Quinn
 

Hi Folks,

There were some compiler warnings that crept in recently in the MAMDA area that I didn't notice at code review time because travis / appveyor builds don't currently fail on warning. Instead, the warning is only reported when the PR is merged into next and the Jenkins CI environment picks it up. I've come back and cleaned these up myself as part of these changes.

With this in mind I have made the following changes to the automatic PR code check systems:

1. I have retired travis. Appveyor now supports Ubuntu as well as Windows builds anyway (and more recent versions of Linux than Travis supports so you generally benefit from stricter gcc warnings). This means there's no longer any compelling reason to support both systems so I've turned travis off.
2. I have updated the build system to include -Werror so CI will now fail in the event of a compiler warning being produced.
3. Linux test builds now use cmake rather than scons. Note the next release will have scons removed so please try it out in your local builds.

Note that I would have also modified valgrind to report on compiler warning but ubuntu looks like it currently reports errors that arent present on centos but that's a fight for another day, so I held fire on that one.

Cheers,
Frank
-- 
Frank Quinn
Cascadium
T: +44 (0) 28 8678 8015


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[noreply] Removed travis from build and added -Werror (#384)
	site_scons/community/windows.py
	mama/c_cpp/src/examples/cpp/mamamsgpublishercpp.cpp
	.appveyor.yml
	release_scripts/ci-run.py
	README.md
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp
	.travis.yml


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #242
  • Build Status: Successful
  • Build Warnings: 0
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] Fixed issue with field names in sub msg
	mama/c_cpp/src/c/msg.c


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #241
  • Build Status: Successful
  • Build Warnings: 1
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] Fixed warnings coming up from recent contributions
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBook.cpp
	mama/c_cpp/src/c/conflation/connection.c
	mama/c_cpp/src/c/transport.c
	common/c_cpp/src/c/linux/machine.c
	mama/c_cpp/src/c/playback/playbackpublisher.c
	mamda/c_cpp/src/cpp/orderbooks/MamdaBookAtomicListener.cpp
	mama/c_cpp/src/c/conflation/connection_int.h
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookEntry.cpp
	mamda/c_cpp/src/cpp/MamdaSubscription.cpp
	mama/c_cpp/src/examples/cpp/mamalistencpp.cpp
	mama/c_cpp/src/examples/cpp/mamalistencachedcpp.cpp
	mamda/c_cpp/src/cpp/MamdaQuoteListener.cpp


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #240
  • Build Status: Successful
  • Build Warnings: 1
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] Added portable install rules for noop lib
	mama/c_cpp/src/c/entitlement/noop/CMakeLists.txt


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #239
  • Build Status: Successful
  • Build Warnings: 8
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1441: Fix non-graceful shutdown of mamalistenc (#179)
	mama/c_cpp/src/examples/c/mamalistenc.c

[fquinn.ni] PLAT-1442: add new parameter to write output to file in mamalistenc
	mama/c_cpp/src/examples/c/mamalistenc.c


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #238
  • Build Status: Successful
  • Build Warnings: 8
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1423 open file with binary flag (#178)
	mama/c_cpp/src/c/playback/playbackcapture.c


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #237
  • Build Status: Successful
  • Build Warnings: 8
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1449: Mamda app includes phantom bid (#177)
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #236
  • Build Status: Successful
  • Build Warnings: 8
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1453: MamaFieldCache::find( ) method seems to exhibit static ret…
	mama/c_cpp/src/cpp/mama/fieldcache/MamaFieldCache.h


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #235
  • Build Status: Successful
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

ci@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] fix mamapublisherc SEGV on exit
	mama/c_cpp/src/examples/c/mamapublisherc.c


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #234
  • Build Status: Successful
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Fixed)

ci@...
 

Some changes have just been added to the origin/next branch!

[Frank Quinn] Fixed issue with serializing vectors to json
	mama/c_cpp/src/c/msg.c


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #233
  • Build Status: Fixed
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Unstable)

ci@...
 

Some changes have just been added to the origin/next branch!

[Frank Quinn] Added mamaMsg_toJsonStringWithDictionary method
	mama/c_cpp/src/c/msg.c
	mama/c_cpp/src/c/mama/msg.h


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #232
  • Build Status: Unstable
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1856
  • Failed: 2
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

jenkins@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] Get rid of vectors in MAMA public headers
	mama/c_cpp/src/cpp/MamaMsg.cpp
	mama/c_cpp/src/cpp/mama/MamaMsgField.h
	mama/c_cpp/src/cpp/mama/mamacpp.h
	mama/c_cpp/src/examples/cpp/mamasymbollistsubscribercpp.cpp
	mamda/c_cpp/src/cpp/mamda/MamdaSubscription.h
	mama/c_cpp/src/cpp/mama/fieldcache/MamaFieldCache.h
	mama/c_cpp/src/cpp/mamacpp.cpp

[fquinn.ni] Some headers were not installed
	mama/c_cpp/src/c/dqstrategyplugin/CMakeLists.txt
	common/c_cpp/src/c/CMakeLists.txt
	mamda/c_cpp/src/cpp/options/CMakeLists.txt
	mamda/c_cpp/src/cpp/news/CMakeLists.txt
	mamda/c_cpp/src/cpp/orderbooks/CMakeLists.txt

[fquinn.ni] Option to generate and install Javadocs
	mama/jni/build.gradle
	mamda/java/build.gradle
	mamda/c_cpp/SConscript
	CMakeLists.txt
	mamda/java/CMakeLists.txt
	mama/c_cpp/SConscript
	mama/jni/src/CMakeLists.txt


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #231
  • Build Status: Successful
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


Code change(s) just landed on origin/next (Successful)

jenkins@...
 

Some changes have just been added to the origin/next branch!

[fquinn.ni] PLAT-1356-3 (#167)
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookBasicDelta.cpp
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookEntry.cpp
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp
	mamda/c_cpp/src/cpp/orderbooks/MamdaBookAtomicListener.cpp
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookConcreteComplexDelta.cpp
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookWriter.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookBasicDeltaList.h
	mamda/c_cpp/src/examples/orderbooks/atomicbookbuilder.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaBookAtomicLevelEntry.h
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookFields.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookEntry.h
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookBasicDeltaList.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaBookAtomicListener.h
	mamda/c_cpp/src/examples/orderbooks/bookticker.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookBasicDelta.h
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBook.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookFields.h
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookListener.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBook.h
	mamda/c_cpp/src/examples/orderbooks/atomicbookticker.cpp
	mamda/c_cpp/src/cpp/orderbooks/mamda/MamdaOrderBookPriceLevel.h

[fquinn.ni] PLAT 1459 (#174)
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp

[fquinn.ni] Used correct addentry, and guarded updateentryposition (#173)
	mamda/c_cpp/src/cpp/orderbooks/MamdaOrderBookPriceLevel.cpp

[fquinn.ni] Java QAP changes
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookPriceLevel.java
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookWriter.java
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookEntry.java
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookFields.java
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookListener.java
	mamda/java/src/main/java/com/wombat/mamda/examples/MamdaBookTicker.java

[fquinn.ni] Whitespace
	mamda/java/src/main/java/com/wombat/mamda/orderbook/MamdaOrderBookListener.java


Results for OpenMAMA_Snapshot_Linux CI run with latest changes:

  • CI Project Name: OpenMAMA_Snapshot_Linux
  • Build Number: #230
  • Build Status: Successful
  • Build Warnings: 7
  • Total Amount of Tests: 1858
  • Passed: 1858
  • Failed: 0
  • Skipped / Disabled: 0

You may also check CI console output to view the full results.


OpenMAMA 6.2.3 Released

Frank Quinn
 

Hi Folks,

 

We are pleased to announce the final release of OpenMAMA 6.2.3 is now available:

 

https://github.com/OpenMAMA/OpenMAMA/releases/tag/OpenMAMA-6.2.3-release

 

This is a hotfix release to address two key issues which were discovered as part of the recent 6.2.2 release:

 

* Restore mamaSubscription RecoverGaps functions accidentally removed in the last release

* Restore missing wombat portability headers in 6.2.2 Release

 

For a complete list of the issues included in this release, please see here: https://github.com/OpenMAMA/OpenMAMA/milestone/9?closed=1

 

Cheers,

Frank

 

 

Frank Quinn

Cascadium

T: +44 (0) 28 8678 8015

E: fquinn@...

W: http://cascadium.io

 

81 - 100 of 2305