Possible bug with MamaSubscription.java


Gary Molloy <g.molloy@...>
 

Hi Chad,

 

Thanks for your email.  We’ve taken a look at MamaSubscription.java and it does indeed look like there is an issue with the management of the closure when using setupSubscription.

 

The fix seems straight forward enough, but will require some testing to ensure it works as expected.  Could I ask you to raise this issue in Bugzilla so that we can track it?  If you could also provide a patch (along with your testing) we can try to get it pushed through a little quicker.

 

Thanks,

Gary

 

 

 

Gary Molloy

SR.LABS Proven High Speed Electronic Trading Solutions

g.molloy@...

 

From: openmama-dev-bounces@... [mailto:openmama-dev-bounces@...] On Behalf Of Meyer, Chad J
Sent: 23 October 2014 20:29
To: openmama-dev@...
Subject: [Openmama-dev] Possible bug with MamaSubscription.java

 

Hi,

 

I’ve been testing the setupSubscription and createSubscription methods found in MamaSubscription.java. Key difference between the two is that setupSubscription is used when a subscription is created but not activated yet where createSubscription creates and activates the subscription.

 

In the setupSubscription, the closure is passed into the JNI layer instead of saving it in the java layer like createSubscription. Without saving this closure in the java layer, the value doesn’t seem to be passed back properly from the JNI layer causing issues.

 

Is this a typo in MamaSubscription.java or is the JNI layer supposed to pass the closure back to the JAVA layer once the subscription is activated?

 

Regards,

 

Chad Meyer | Corporate & Investment Bank | PIM Market Data Services | J.P. Morgan | 4 Metrotech Center 23rd Floor Brooklyn, NY 11201 | Tel: (718) 242-5165 | M: (215) 801-2606 | chad.j.meyer@...

 

This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates. This transmission may contain information that is proprietary, privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to European legal entities.


Chad Meyer
 

Hi,

 

I’ve been testing the setupSubscription and createSubscription methods found in MamaSubscription.java. Key difference between the two is that setupSubscription is used when a subscription is created but not activated yet where createSubscription creates and activates the subscription.

 

In the setupSubscription, the closure is passed into the JNI layer instead of saving it in the java layer like createSubscription. Without saving this closure in the java layer, the value doesn’t seem to be passed back properly from the JNI layer causing issues.

 

Is this a typo in MamaSubscription.java or is the JNI layer supposed to pass the closure back to the JAVA layer once the subscription is activated?

 

Regards,

 

Chad Meyer | Corporate & Investment Bank | PIM Market Data Services | J.P. Morgan | 4 Metrotech Center 23rd Floor Brooklyn, NY 11201 | Tel: (718) 242-5165 | M: (215) 801-2606 | chad.j.meyer@...

 

This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates. This transmission may contain information that is proprietary, privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to European legal entities.