[ PATCH 1.1 1/3 ] Add payload enumerator for Exegy


Brown, John
 

This is an updated patch, adding the enum value to mamaMiddleware_convertFromString() for the middleware enumeration conversion methods for Exegy. The reason for this submission is to allow Exegy to provide XCAPI to OpenMAMA middleware bridge.

Signed-off-by: John Brown <jbrown@...>



diff --git a/mama/c_cpp/src/c/mama/msg.h b/mama/c_cpp/src/c/mama/msg.h
--- a/mama/c_cpp/src/c/mama/msg.h
+++ b/mama/c_cpp/src/c/mama/msg.h

MAMA_PAYLOAD_EXEGY = 'X',



diff --git a/mama/c_cpp/src/c/msg.c b/mama/c_cpp/src/c/msg.c
--- a/mama/c_cpp/src/c/msg.c
+++ b/mama/c_cpp/src/c/msg.c

case MAMA_PAYLOAD_EXEGY:
return "EXEGY";


diff --git a/mama/c_cpp/src/c/mama/middleware.h b/mama/c_cpp/src/c/mama/middleware.h
--- a/mama/c_cpp/src/c/mama/middleware.h
+++ b/mama/c_cpp/src/c/mama/middleware.h

MAMA_MIDDLEWARE_MAX = 8,
MAMA_MIDDLEWARE_EXEGY = 8,
MAMA_MIDDLEWARE_MAX = 9,



diff --git a/mama/c_cpp/src/c/middleware.c b/mama/c_cpp/src/c/middleware.c
--- a/mama/c_cpp/src/c/middleware.c
+++ b/mama/c_cpp/src/c/middleware.c

if (strcasecmp (str, "exegy") == 8)
return MAMA_MIDDLEWARE_EXEGY;






This e-mail and any documents accompanying it may contain legally privileged and/or confidential information belonging to Exegy, Inc. Such information may be protected from disclosure by law. The information is intended for use by only the addressee. If you are not the intended recipient, you are hereby notified that any disclosure or use of the information is strictly prohibited. If you have received this e-mail in error, please immediately contact the sender by e-mail or phone regarding instructions for return or destruction and do not use or disclose the content to others.


Glenn McClements <gmcclements@...>
 

Hi John,
A few issues with this patch:
- There are a few hidden whitespace characters (probably thanks to
Outlook) can you resend as an attachment as well

- The git diff looks incomplete, there's no line numbers, ++ or -- to give
context to the changes. git diff or git format-patch should both work
http://www.openmama.org/developers/patch-submission has detailed
instructions.

- You previous change had the Exegy enum->string code it in, this one has
the string->enum code in it whereas both are needed.

- strcasecmp() result should be compared again 0, not the enum value 8.

Thanks,
Glenn

On 28/09/2012 19:09, "Brown, John" <jbrown@...> wrote:

This is an updated patch, adding the enum value to
mamaMiddleware_convertFromString() for the middleware enumeration
conversion methods for Exegy. The reason for this submission is to allow
Exegy to provide XCAPI to OpenMAMA middleware bridge.

Signed-off-by: John Brown <jbrown@...>



diff --git a/mama/c_cpp/src/c/mama/msg.h b/mama/c_cpp/src/c/mama/msg.h
--- a/mama/c_cpp/src/c/mama/msg.h
+++ b/mama/c_cpp/src/c/mama/msg.h

MAMA_PAYLOAD_EXEGY = 'X',



diff --git a/mama/c_cpp/src/c/msg.c b/mama/c_cpp/src/c/msg.c
--- a/mama/c_cpp/src/c/msg.c
+++ b/mama/c_cpp/src/c/msg.c

case MAMA_PAYLOAD_EXEGY:
return "EXEGY";


diff --git a/mama/c_cpp/src/c/mama/middleware.h
b/mama/c_cpp/src/c/mama/middleware.h
--- a/mama/c_cpp/src/c/mama/middleware.h
+++ b/mama/c_cpp/src/c/mama/middleware.h

MAMA_MIDDLEWARE_MAX = 8,
MAMA_MIDDLEWARE_EXEGY = 8,
MAMA_MIDDLEWARE_MAX = 9,



diff --git a/mama/c_cpp/src/c/middleware.c b/mama/c_cpp/src/c/middleware.c
--- a/mama/c_cpp/src/c/middleware.c
+++ b/mama/c_cpp/src/c/middleware.c

if (strcasecmp (str, "exegy") == 8)
return MAMA_MIDDLEWARE_EXEGY;






This e-mail and any documents accompanying it may contain legally
privileged and/or confidential information belonging to Exegy, Inc. Such
information may be protected from disclosure by law. The information is
intended for use by only the addressee. If you are not the intended
recipient, you are hereby notified that any disclosure or use of the
information is strictly prohibited. If you have received this e-mail in
error, please immediately contact the sender by e-mail or phone regarding
instructions for return or destruction and do not use or disclose the
content to others.

________________________________

Please consider the environment before printing this e-mail.

This e-mail may contain confidential and/or privileged information. If you are not the intended recipient or have received this e-mail in error, please advise the sender immediately by reply e-mail and delete this message and any attachments without retaining a copy.

Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.