[PATCH] Build error within pcapi Lock.h, due to modifications for Openmama


Adrienne Ambrose <AAmbrose@...>
 

TESTING

This was a build fail when applying OpenMAMA patch – “MSVC - Visual Studio Solutions File Updates”

There was simply a missing #include, any application that includes Lock.h but not wConfig.h would fail to build before this fix.

 

 

 

 

From be209b4935fe4f1719ec6b9f7eac211014160b58 Mon Sep 17 00:00:00 2001

From: A Ambrose <aambrose@...>

Date: Tue, 24 Jun 2014 14:41:25 +0100

Subject: [PATCH] Build error when openmama patch for VS solution files caused

Enterprise build fail.

 

Modification to Lock.h to correct build error when openmama patch for

Microsoft Visual Studio solution file updates caused Enterprise build to

fail.

[OMAMA-274]

 

Signed-off-by: A Ambrose <aambrose@...>

---

common/c_cpp/src/cpp/wombat/Lock.h | 1 +

1 file changed, 1 insertion(+)

 

diff --git a/common/c_cpp/src/cpp/wombat/Lock.h b/common/c_cpp/src/cpp/wombat/Lock.h

index 3c9760f..fa04c2e 100644

--- a/common/c_cpp/src/cpp/wombat/Lock.h

+++ b/common/c_cpp/src/cpp/wombat/Lock.h

@@ -22,6 +22,7 @@

#define LockCppH__

 #include <memory>

+#include "wombat/wConfig.h"

 namespace Wombat {

--

1.8.3.1

 


This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of IntercontinentalExchange Group, Inc. (ICE), NYSE Euronext or any of their subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.


Damian Maguire <DMaguire@...>
 

Cheers Adrienne, 

I've raised BZ140 to track this one, so I'll add any feedback there.

D

From: Adrienne Ambrose <AAmbrose@...>
Date: Tuesday, June 24, 2014 2:55 PM
To: "openmama-dev@..." <openmama-dev@...>
Subject: [Openmama-dev] [PATCH] Build error within pcapi Lock.h, due to modifications for Openmama

TESTING

This was a build fail when applying OpenMAMA patch – “MSVC - Visual Studio Solutions File Updates”

There was simply a missing #include, any application that includes Lock.h but not wConfig.h would fail to build before this fix.

 

 

 

 

From be209b4935fe4f1719ec6b9f7eac211014160b58 Mon Sep 17 00:00:00 2001

From: A Ambrose <aambrose@...>

Date: Tue, 24 Jun 2014 14:41:25 +0100

Subject: [PATCH] Build error when openmama patch for VS solution files caused

Enterprise build fail.

 

Modification to Lock.h to correct build error when openmama patch for

Microsoft Visual Studio solution file updates caused Enterprise build to

fail.

[OMAMA-274]

 

Signed-off-by: A Ambrose <aambrose@...>

---

common/c_cpp/src/cpp/wombat/Lock.h | 1 +

1 file changed, 1 insertion(+)

 

diff --git a/common/c_cpp/src/cpp/wombat/Lock.h b/common/c_cpp/src/cpp/wombat/Lock.h

index 3c9760f..fa04c2e 100644

--- a/common/c_cpp/src/cpp/wombat/Lock.h

+++ b/common/c_cpp/src/cpp/wombat/Lock.h

@@ -22,6 +22,7 @@

#define LockCppH__

 #include <memory>

+#include "wombat/wConfig.h"

 namespace Wombat {

--

1.8.3.1

 


This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of IntercontinentalExchange Group, Inc. (ICE), NYSE Euronext or any of their subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.

This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of Intercontinental Exchange, Inc. (ICE), Euronext or any of their subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.