[PATCH] QPID Fix For Missing Method Name


Philip Preston
 

Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@mac.com>
---
mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
"Error Subscribing to %s : %s",
impl->mIncomingAddress,
PN_MESSENGER_ERROR(impl->mIncoming));
- (impl->mIncoming);
+ qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
return MAMA_STATUS_PLATFORM;
}
}
--
2.3.2 (Apple Git-55)


Frank Quinn <fquinn.ni@...>
 

Thanks Phil - both look good.

You want to do this via pull request or the old fashioned way?

https://github.com/OpenMAMA/OpenMAMA/wiki/Submission-Process

Cheers,
Frank


On Mon, 21 Sep 2015 22:41 Philip Preston <philippreston@...> wrote:
Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@...>
---
 mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
                           "Error Subscribing to %s : %s",
                           impl->mIncomingAddress,
                           PN_MESSENGER_ERROR(impl->mIncoming));
-                (impl->mIncoming);
+                qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
                 return MAMA_STATUS_PLATFORM;
             }
         }
--
2.3.2 (Apple Git-55)



_______________________________________________
Openmama-dev mailing list
Openmama-dev@...
https://lists.openmama.org/mailman/listinfo/openmama-dev


Philip Preston
 

Can do via pull request.


Another minor one - local to Darwin.


On 21 Sep 2015, at 22:54, Frank Quinn <fquinn.ni@...> wrote:

Thanks Phil - both look good.

You want to do this via pull request or the old fashioned way?

https://github.com/OpenMAMA/OpenMAMA/wiki/Submission-Process

Cheers,
Frank


On Mon, 21 Sep 2015 22:41 Philip Preston <philippreston@...> wrote:
Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@...>
---
 mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
                           "Error Subscribing to %s : %s",
                           impl->mIncomingAddress,
                           PN_MESSENGER_ERROR(impl->mIncoming));
-                (impl->mIncoming);
+                qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
                 return MAMA_STATUS_PLATFORM;
             }
         }
--
2.3.2 (Apple Git-55)



_______________________________________________
Openmama-dev mailing list
Openmama-dev@...
https://lists.openmama.org/mailman/listinfo/openmama-dev


Frank Quinn <fquinn.ni@...>
 

Thanks Phil,

Yeah that works - another small, related change.

Cheers,
Frank


On Mon, 21 Sep 2015 23:02 Philip Preston <philippreston@...> wrote:
Can do via pull request.


Another minor one - local to Darwin.


On 21 Sep 2015, at 22:54, Frank Quinn <fquinn.ni@...> wrote:

Thanks Phil - both look good.

You want to do this via pull request or the old fashioned way?

https://github.com/OpenMAMA/OpenMAMA/wiki/Submission-Process

Cheers,
Frank


On Mon, 21 Sep 2015 22:41 Philip Preston <philippreston@...> wrote:
Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@...>
---
 mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
                           "Error Subscribing to %s : %s",
                           impl->mIncomingAddress,
                           PN_MESSENGER_ERROR(impl->mIncoming));
-                (impl->mIncoming);
+                qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
                 return MAMA_STATUS_PLATFORM;
             }
         }
--
2.3.2 (Apple Git-55)



_______________________________________________
Openmama-dev mailing list
Openmama-dev@...
https://lists.openmama.org/mailman/listinfo/openmama-dev


Philip Preston
 

On 21 Sep 2015, at 23:06, Frank Quinn <fquinn.ni@...> wrote:

Thanks Phil,

Yeah that works - another small, related change.

Cheers,
Frank


On Mon, 21 Sep 2015 23:02 Philip Preston <philippreston@...> wrote:
Can do via pull request.


Another minor one - local to Darwin.


On 21 Sep 2015, at 22:54, Frank Quinn <fquinn.ni@...> wrote:

Thanks Phil - both look good.

You want to do this via pull request or the old fashioned way?

https://github.com/OpenMAMA/OpenMAMA/wiki/Submission-Process

Cheers,
Frank


On Mon, 21 Sep 2015 22:41 Philip Preston <philippreston@...> wrote:
Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@...>
---
 mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
                           "Error Subscribing to %s : %s",
                           impl->mIncomingAddress,
                           PN_MESSENGER_ERROR(impl->mIncoming));
-                (impl->mIncoming);
+                qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
                 return MAMA_STATUS_PLATFORM;
             }
         }
--
2.3.2 (Apple Git-55)



_______________________________________________
Openmama-dev mailing list
Openmama-dev@...
https://lists.openmama.org/mailman/listinfo/openmama-dev



Frank Quinn <f.quinn@...>
 

Thanks Phil,

 

That’s merged into the next branch now.

 

Cheers,

Frank

 

From: openmama-dev-bounces@... [mailto:openmama-dev-bounces@...] On Behalf Of Philip Preston
Sent: 21 September 2015 23:46
To: Frank Quinn <fquinn.ni@...>
Cc: OpenMAMA Dev List <openmama-dev@...>
Subject: Re: [Openmama-dev] [PATCH] QPID Fix For Missing Method Name

 

https://github.com/OpenMAMA/OpenMAMA/pull/24

 

On 21 Sep 2015, at 23:06, Frank Quinn <fquinn.ni@...> wrote:

 

Thanks Phil,

Yeah that works - another small, related change.

Cheers,
Frank

 

On Mon, 21 Sep 2015 23:02 Philip Preston <philippreston@...> wrote:

Can do via pull request.

 

 

Another minor one - local to Darwin.

 

 

On 21 Sep 2015, at 22:54, Frank Quinn <fquinn.ni@...> wrote:

 

Thanks Phil - both look good.

You want to do this via pull request or the old fashioned way?

https://github.com/OpenMAMA/OpenMAMA/wiki/Submission-Process

Cheers,
Frank

 

On Mon, 21 Sep 2015 22:41 Philip Preston <philippreston@...> wrote:

Missing method name in transport.c

Signed-off-by: Phil Preston <philippreston@...>
---
 mama/c_cpp/src/c/bridge/qpid/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mama/c_cpp/src/c/bridge/qpid/transport.c b/mama/c_cpp/src/c/bridge/qpid/transport.c
index ab9755c..8b5ceba 100644
--- a/mama/c_cpp/src/c/bridge/qpid/transport.c
+++ b/mama/c_cpp/src/c/bridge/qpid/transport.c
@@ -938,7 +938,7 @@ qpidBridgeMamaTransportImpl_start (qpidTransportBridge* impl)
                           "Error Subscribing to %s : %s",
                           impl->mIncomingAddress,
                           PN_MESSENGER_ERROR(impl->mIncoming));
-                (impl->mIncoming);
+                qpidBridgeMamaTransportImpl_stopProtonMessenger(impl->mIncoming);
                 return MAMA_STATUS_PLATFORM;
             }
         }
--
2.3.2 (Apple Git-55)



_______________________________________________
Openmama-dev mailing list
Openmama-dev@...
https://lists.openmama.org/mailman/listinfo/openmama-dev

 

 


The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to this message and deleting it from your computer. Thank you. SR Labs LLC